Add conversations.requestSharedInvite.approve/deny APIs#1365
Merged
seratch merged 1 commit intoslackapi:mainfrom Sep 13, 2024
Merged
Add conversations.requestSharedInvite.approve/deny APIs#1365seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
seratch
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
============================================
+ Coverage 74.73% 74.78% +0.05%
- Complexity 4268 4280 +12
============================================
Files 457 457
Lines 13278 13299 +21
Branches 1369 1370 +1
============================================
+ Hits 9923 9946 +23
+ Misses 2553 2550 -3
- Partials 802 803 +1 ☔ View full report in Codecov by Sentry. |
seratch
force-pushed
the
connect-governance-apis
branch
from
64b0169 to
f0dcace
Compare
filmaj
approved these changes
Sep 12, 2024
WilliamBergamin
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds two endpoint support to slack-api-client library. Usually, we add end-to-end autoamted tests for this type of addition, but let me skip this time for now. The reason is that it's not so easy to set up such an automation with these APIs. For the future, I don't think these APIs will make lots of changes, so we can do manual testing as necessary.
I'd like to hold off adding conversations.requestSharedInvite.list API this time because it's not yet publicly available.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.