Configuring with pyproject.toml#996
Conversation
|
@WilliamBergamin Thanks for proposing this! As long as the release process goes well, migrating to pyproject.toml should be a good way to go! Can you adjust the CI build settings to pass the tests? Also, checking if the package upload works using https://test.pypi.org/ would be safe. |
.github/workflows/codecov.yml
Outdated
| @@ -28,10 +28,10 @@ jobs: | |||
| run: | | |||
| python setup.py install | |||
There was a problem hiding this comment.
Perhaps, need changes on this part
There was a problem hiding this comment.
Great point, I've fixed up the CI parts to work with the new changes
NOTE: there are some limitation with python 3.6 that required work arounds
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 181 181
Lines 6312 6312
=======================================
Hits 5792 5792
Misses 520 520 ☔ View full report in Codecov by Sentry. |
|
@seratch I've deployed a test package to https://test.pypi.org/project/slack-bolt/ and everything seems to be the same apart from the "Homepage" link being renamed to "homepage" Could you take a look and let me know if you find any discrepancies |
|
Thank you! I just confirmed the package file uploaded to test PyPI works without any issues. |
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
One nit comment but this looks great to me! After fixing the minor error in a comment, you can merge this PR.
|
Also, when you merge this, please use "Squash and merge" button to make the diffs simpler |
Co-authored-by: Kazuhiro Sera <[email protected]>
2 participants
These changes started out as an exploration of the
pyproject.tomlfile. In the process I learnt that since PEP 621, the Python community selectedpyproject.tomlas a standard way of specifying project metadata.This PR aims to introduce changes that make the
pyproject.tomlthe default configuration file for bolt-python, there are some slight differences but the testing, packaging and publishing behaviors should remain the same as they wereI've opted to rely on the Requirements File Format pattern to import test dependencies since it yields a clear distinction between the project dependencies and the development dependencies
Is the
pyproject.tomlconfiguration pattern something we would want to adopt in our python projects?Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.