Skip to content

Commit 9bcbff8

Browse files
seratchfilmaj
andauthored
Apply suggestions from code review
Co-authored-by: Fil Maj <[email protected]>
1 parent b0a6576 commit 9bcbff8

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

slack_bolt/app/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1211,7 +1211,7 @@ def _init_context(self, req: BoltRequest):
12111211
# in the interest of runtime performance/memory footprint optimization.
12121212
# However, developers may want to replace the token held by req.context.client in some situations.
12131213
# In this case, this behavior can result in thread-unsafe data modification on `self._client`.
1214-
# (`self._client` a.k.a. `app.clint` is a singleton object per an App instance)
1214+
# (`self._client` a.k.a. `app.client` is a singleton object per an App instance)
12151215
# Thus, we've changed the behavior to create a new instance per request regardless of token argument
12161216
# in the App initialization starting v1.15.
12171217
# The overhead brought by this change is slight so that we believe that it is ignorable in any cases.

slack_bolt/app/async_app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1245,7 +1245,7 @@ def _init_context(self, req: AsyncBoltRequest):
12451245
# in the interest of runtime performance/memory footprint optimization.
12461246
# However, developers may want to replace the token held by req.context.client in some situations.
12471247
# In this case, this behavior can result in thread-unsafe data modification on `self._client`.
1248-
# (`self._client` a.k.a. `app.clint` is a singleton object per an App instance)
1248+
# (`self._client` a.k.a. `app.client` is a singleton object per an App instance)
12491249
# Thus, we've changed the behavior to create a new instance per request regardless of token argument
12501250
# in the App initialization starting v1.15.
12511251
# The overhead brought by this change is slight so that we believe that it is ignorable in any cases.

0 commit comments

Comments
 (0)