Skip to content

Bradh workflow extension support#546

Merged
stevengill merged 5 commits intoslackapi:feat-workflow-stepsfrom
selfcontained:bradh-workflow-extension-support
Jul 20, 2020
Merged

Bradh workflow extension support#546
stevengill merged 5 commits intoslackapi:feat-workflow-stepsfrom
selfcontained:bradh-workflow-extension-support

Conversation

@selfcontained
Copy link
Copy Markdown
Contributor

@selfcontained selfcontained commented Jul 15, 2020

Summary

This PR adds support for a new feature entering open beta called Workflow Steps from Apps. It allows Slack apps to provide custom steps for Slack Workflows. This new feature requires the following updates to Bolt, encompassed in these changes:

  • A new workflow_step_edit action
  • A new workflow_step_execute event
  • Exclusion of the say function from the workflow_step_edit handler
  • Updating getTypeAndConversation() to allow workflow_step_edit action to fall into the action handling logic

Requirements (place an x in each [ ])

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #546 into feat-workflow-steps will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat-workflow-steps     #546   +/-   ##
====================================================
  Coverage                83.13%   83.13%           
====================================================
  Files                        7        7           
  Lines                      593      593           
  Branches                   184      184           
====================================================
  Hits                       493      493           
  Misses                      68       68           
  Partials                    32       32
Impacted Files Coverage Δ
src/helpers.ts 90.90% <100.00%> (ø)
src/ExpressReceiver.ts 65.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b37456...22bcdfb. Read the comment docs.

@clavin clavin added the enhancement M-T: A feature request for new functionality label Jul 15, 2020
@seratch seratch requested review from misscoded and stevengill July 15, 2020 23:36
misscoded
misscoded reviewed Jul 16, 2020
View reviewed changes
Comment thread src/types/actions/workflow-step-edit.ts Outdated
trigger_id: string;
user: {
id: string;
name: string;
Copy link
Copy Markdown
Contributor

@misscoded misscoded Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user object in action payload has a key of username rather than name

misscoded
misscoded reviewed Jul 16, 2020
View reviewed changes
Comment thread src/types/actions/workflow-step-edit.ts
action_ts: string; // undocumented
workflow_step: {
workflow_id: string;
step_id: string;
Copy link
Copy Markdown
Contributor

@misscoded misscoded Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_step also has keys for inputs and outputs in either case (add vs. edit)

misscoded
misscoded reviewed Jul 16, 2020
View reviewed changes
Comment thread src/types/events/base-events.ts Outdated
callback_id: string;
workflow_step: {
workflow_step_execute_id: string;
workflow_id: string,
Copy link
Copy Markdown
Contributor

@misscoded misscoded Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few commas here instead of semi-colons

misscoded
misscoded requested changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions

Comment thread src/types/actions/workflow-step-edit.ts Outdated
Comment thread src/types/actions/workflow-step-edit.ts
Comment thread src/types/events/base-events.ts Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

misscoded
misscoded reviewed Jul 16, 2020
View reviewed changes
Comment thread src/types/actions/workflow-step-edit.ts
trigger_id: string;
user: {
id: string;
username: string;
Copy link
Copy Markdown
Contributor

@misscoded misscoded Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed from name to username based on the payloads

Copy link
Copy Markdown
Contributor Author

@selfcontained selfcontained Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixes all of those 😄

@stevengill stevengill merged commit 92edcab into slackapi:feat-workflow-steps Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misscoded misscoded misscoded approved these changes

@stevengill stevengill Awaiting requested review from stevengill

Assignees

@misscoded misscoded

Labels

enhancement M-T: A feature request for new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@selfcontained @CLAassistant @misscoded @seratch @stevengill @clavin