Skip to content

Comments

feat(types): add block actions for context action elements#2665

Merged
zimeg merged 1 commit intoai-appsfrom
zimeg-feat-context-actions-block-actions
Oct 3, 2025
Merged

feat(types): add block actions for context action elements#2665
zimeg merged 1 commit intoai-appsfrom
zimeg-feat-context-actions-block-actions

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Oct 3, 2025

Summary

This PR adds block actions for the context_action elements "feedback_buttons" and "icon_button" for filtering types.

Preview

The following listener guarantees the value exists for this action if the return is skipped:

app.action({ type: "block_actions", action_id: "feedback" }, async ({ body, logger }) => {
  if (body.actions[0].type !== 'feedback_buttons') {
    return;
  }
  const value = body.actions[0].value;
  logger.info(value);
}

Requirements

@zimeg zimeg requested review from mwbrooks and srtaalej October 3, 2025 00:44
@zimeg zimeg self-assigned this Oct 3, 2025
@zimeg zimeg added enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific labels Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ai-apps@43f6f03). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff             @@
##             ai-apps    #2665   +/-   ##
==========================================
  Coverage           ?   93.40%           
==========================================
  Files              ?       37           
  Lines              ?     7613           
  Branches           ?      668           
==========================================
  Hits               ?     7111           
  Misses             ?      497           
  Partials           ?        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg mentioned this pull request Oct 3, 2025
Merged
3 tasks
mwbrooks
mwbrooks approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for catching and fixing this issue! It's unfortunate that we have types between Bolt and @slack/types but that's a story for another day. This looks good to me!

@zimeg
Copy link
Member Author

zimeg commented Oct 3, 2025

@mwbrooks We're thinking so much alike! I'm glad to find a quick change now, but agree we should move this elsewhere 👁️‍🗨️ ✨

@zimeg zimeg merged commit 5f19ce3 into ai-apps Oct 3, 2025
19 checks passed
@zimeg zimeg deleted the zimeg-feat-context-actions-block-actions branch October 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@srtaalej srtaalej Awaiting requested review from srtaalej

Assignees

@zimeg zimeg

Labels

enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg @mwbrooks