Skip to content

Comments

fix(deps): update @slack/web-api to 7.10.0-aiAppsBeta.1#2654

Merged
mwbrooks merged 1 commit intoai-appsfrom
mwbrooks-ai-apps-pinned-dep
Sep 12, 2025
Merged

fix(deps): update @slack/web-api to 7.10.0-aiAppsBeta.1#2654
mwbrooks merged 1 commit intoai-appsfrom
mwbrooks-ai-apps-pinned-dep

Conversation

@mwbrooks
Copy link
Member

Summary

This pull request fixes an issue where the incorrect version of @slack/web-api can be installed by updating the version of @slack/web-api from the label "feat-ai-apps" to the pinned version "7.10.0-aiAppsBeta.1".

Honestly, we're unclear why it's happening. When an app uses the beta release @slack/[email protected], then @slack/[email protected] is installed as Bolt's sub-dependency. However, if the app explicitly declares the dependency @slack/[email protected] then Bolt's sub-dependency is correctly 7.10.0-aiAppsBeta.1.

Reviewers

In the bolt-js project:

# Clone this branch
$ gh pr checkout ...

# Clear the package's cache
$ rm -rf node_modules package-lock.json

# Install the package dependencies
$ npm install

# Link this package
$ npm link

In your sample app project:

# Change into the project
$ cd my-project/

# Clear the package's cache
$ rm -rf node_modules package-lock.json

# Remove web-api from package.json
$ vim package.json
# → Remove "dependencies": { ..., ""@slack/web-api": "7.10.0-aiAppsBeta.1", ... }

# Link the local bolt-js
$ npm link @slack/bolt

# Install the dependencies
$ npm install

# Confirm bolt-js is pointing to your local project
$ npm list

# Test the project
$ npm start

Requirements (place an x in each [ ])

@mwbrooks mwbrooks requested a review from zimeg September 12, 2025 21:00
@mwbrooks mwbrooks self-assigned this Sep 12, 2025
@mwbrooks mwbrooks added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Sep 12, 2025
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ai-apps@4e78285). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             ai-apps    #2654   +/-   ##
==========================================
  Coverage           ?   93.37%           
==========================================
  Files              ?       37           
  Lines              ?     7581           
  Branches           ?      667           
==========================================
  Hits               ?     7079           
  Misses             ?      497           
  Partials           ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks LGTM! I found some strangeness in testing around link but after adjusting the app package.json with the following all things seem to work as expected!

{
  "dependencies": {
    "@slack/bolt": "file:../../tools/bolt-js/slack-bolt-4.4.0-aiAppsBeta.1.tgz"
  }
}

"@slack/socket-mode": "^2.0.5",
"@slack/types": "^2.16.0",
"@slack/web-api": "feat-ai-apps",
"@slack/web-api": "7.10.0-aiAppsBeta.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 praise: Nice. It makes sense to me that we'd want to use a pinned version here to make it clear that certain changes here match upstream updates.

@mwbrooks mwbrooks merged commit 0c11257 into ai-apps Sep 12, 2025
19 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-ai-apps-pinned-dep branch September 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants