Skip to content

Comments

docs: use the app logger in examples#2651

Merged
zimeg merged 1 commit intomainfrom
zimeg-docs-app-logger
Sep 12, 2025
Merged

docs: use the app logger in examples#2651
zimeg merged 1 commit intomainfrom
zimeg-docs-app-logger

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Sep 11, 2025

Summary

This PR replaces a few more instances of console.log with app.logger following #2365 🪵

Requirements

@zimeg zimeg added this to the 4.4.1 milestone Sep 11, 2025
@zimeg zimeg self-assigned this Sep 11, 2025
@zimeg zimeg added docs M-T: Documentation work only area:examples issues related to example or sample code labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (44ceb2f) to head (8533eaf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2651   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          37       37           
  Lines        7581     7581           
  Branches      667      667           
=======================================
  Hits         7079     7079           
  Misses        497      497           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwbrooks
mwbrooks approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

hello-ashleyintech
hello-ashleyintech approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.logger.info('LGTM!');

@zimeg
Copy link
Member Author

zimeg commented Sep 11, 2025

👁️‍🗨️ Related to #2627.

lukegalbraithrussell
lukegalbraithrussell approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prob surface these examples in the site. future project!

@zimeg
Copy link
Member Author

zimeg commented Sep 12, 2025

@mwbrooks @hello-ashleyintech @lukegalbraithrussell Incredible thanks to all the kind reviews 🎁

we should prob surface these examples in the site. future project!

I agree much it'd be great to reference these snippets within docs! I noticed a changed sample caused CI to fail earlier which means our testing is working - that'd be nice confidence to share around 👾 ✨

For now let's merge this PR. I think the README update will happen soonest now 🚢

@zimeg zimeg merged commit d87726f into main Sep 12, 2025
28 of 31 checks passed
@zimeg zimeg deleted the zimeg-docs-app-logger branch September 12, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@hello-ashleyintech hello-ashleyintech hello-ashleyintech approved these changes

@lukegalbraithrussell lukegalbraithrussell lukegalbraithrussell approved these changes

@WilliamBergamin WilliamBergamin Awaiting requested review from WilliamBergamin

Assignees

@zimeg zimeg

Labels

area:examples issues related to example or sample code docs M-T: Documentation work only

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zimeg @mwbrooks @hello-ashleyintech @lukegalbraithrussell