Skip to content

Comments

Update event-listening.md#2584

Merged
hello-ashleyintech merged 3 commits intoslackapi:mainfrom
jfbn:update-events-concept-readme
Jul 1, 2025
Merged

Update event-listening.md#2584
hello-ashleyintech merged 3 commits intoslackapi:mainfrom
jfbn:update-events-concept-readme

Conversation

@jfbn
Copy link
Contributor

@jfbn jfbn commented Jun 26, 2025

Summary

Resolves issue#2583 by updating the markdown document for the Events Listening concept page.

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech self-requested a review June 26, 2025 15:41
@hello-ashleyintech hello-ashleyintech added enhancement M-T: A feature request for new functionality docs M-T: Documentation work only and removed enhancement M-T: A feature request for new functionality labels Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (c2b097d) to head (837c206).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2584   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          37       37           
  Lines        7578     7578           
  Branches      666      666           
=======================================
  Hits         7076     7076           
  Misses        497      497           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting this! 😄 one small change requested!

@jfbn
Copy link
Contributor Author

jfbn commented Jun 27, 2025

LGTM, thanks for submitting this! 😄 one small change requested!

Thanks for the feedback. I committed your suggested changes. Good catch with the missing starting /!

@jfbn jfbn requested a review from hello-ashleyintech June 27, 2025 04:32
@hello-ashleyintech hello-ashleyintech merged commit b832a53 into slackapi:main Jul 1, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Events Listening concept page does not describe URL requirement

2 participants