Fix: allows Assistant say function to properly pass metadata#2569
Merged
WilliamBergamin merged 3 commits intoslackapi:mainfrom Jun 18, 2025
jamessimone:fix/assistant-create-say-with-supplemental-context
Merged
Fix: allows Assistant say function to properly pass metadata#2569WilliamBergamin merged 3 commits intoslackapi:mainfrom jamessimone:fix/assistant-create-say-with-supplemental-context
WilliamBergamin merged 3 commits intoslackapi:mainfrom
jamessimone:fix/assistant-create-say-with-supplemental-context
Conversation
…tadata context arguments passed to it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
+ Coverage 93.35% 93.37% +0.01%
==========================================
Files 37 37
Lines 7575 7578 +3
Branches 664 666 +2
==========================================
+ Hits 7072 7076 +4
+ Misses 498 497 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
Jun 18, 2025
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
This looks good to me 💯 thanks for putting this together
| sinon.assert.calledWith(fakeClient.chat.postMessage, expectedParams); | ||
| }); | ||
|
|
||
| it('say should be called with message_metadata that supplements thread context', async () => { |
Contributor
Author
There was a problem hiding this comment.
Of course! Thanks for reviewing
Contributor
Author
There was a problem hiding this comment.
@WilliamBergamin any word on when the next release will be cut?
zimeg
added
bug
jamessimone
deleted the
fix/assistant-create-say-with-supplemental-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where say function for Assistant improperly overwrites metadata context arguments passed to it
Requirements (place an
xin each[ ])