Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 36 36
Lines 7443 7443
Branches 652 652
=======================================
Hits 6940 6940
Misses 498 498
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
approved these changes
May 9, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looking good! Thanks for putting in the work to migrate us to the latest sinon! 🧪
|
|
||
| assert.deepEqual(actualReturn, dummyReturn); | ||
| assert.deepEqual(dummyParams, fakeReceiver.stop.firstCall.args); | ||
| assert.deepEqual(fakeReceiver.stop.firstCall.args, dummyParams as unknown); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to bump the version of
sinonandtype/sinonOriginally thought the tests could take advantage of sinon.promise but its not needed finally 🤔 regardless the work is done so might as well merge it
Requirements (place an
xin each[ ])