Skip to content

Comments

fix: always attach the function inputs to the context if available#2517

Merged
zimeg merged 1 commit intomainfrom
zimeg-fix-context-function-inputs
May 5, 2025
Merged

fix: always attach the function inputs to the context if available#2517
zimeg merged 1 commit intomainfrom
zimeg-fix-context-function-inputs

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented May 5, 2025

Summary

This PR attaches the executed step inputs values of a function_executed event to the context to match the behavior of block_actions 🙏

Context: #2513 (comment)

Requirements

@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels May 5, 2025
@zimeg zimeg added this to the 4.2.2 milestone May 5, 2025
@zimeg zimeg requested a review from WilliamBergamin May 5, 2025 16:52
@zimeg zimeg self-assigned this May 5, 2025
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (a47374a) to head (a36f05a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files          36       36           
  Lines        7442     7443    +1     
  Branches      649      648    -1     
=======================================
+ Hits         6919     6920    +1     
  Misses        518      518           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@zimeg
Copy link
Member Author

zimeg commented May 5, 2025

@WilliamBergamin Then let's merge this for a next release!

@zimeg zimeg merged commit e57cec3 into main May 5, 2025
18 checks passed
@zimeg zimeg deleted the zimeg-fix-context-function-inputs branch May 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants