Skip to content

Comments

chore(deps): update @slack/web-api requirement from ^7.8.0 to ^7.9.1#2473

Merged
dependabot[bot] merged 1 commit intomainfrom
dependabot/npm_and_yarn/slack/web-api-tw-7.9.1
Mar 27, 2025
Merged

chore(deps): update @slack/web-api requirement from ^7.8.0 to ^7.9.1#2473
dependabot[bot] merged 1 commit intomainfrom
dependabot/npm_and_yarn/slack/web-api-tw-7.9.1

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 27, 2025

Updates the requirements on @slack/web-api to permit the latest version.

Release notes

Sourced from @​slack/web-api's releases.

@​slack/web-api@​7.9.1

What's Changed

This release fixes a bug where setting allowAbsoluteUrls to false caused the filesUploadV2 method to error when uploading files. Files can now be uploaded with allowAbsoluteUrls set to false.

Bug fixes 🐛

Maintenance 🧰

Full Changelog: https://github.com/slackapi/node-slack-sdk/compare/@​slack/web-api@​7.9.0...@​slack/web-api@​7.9.1 Milestone: https://github.com/slackapi/node-slack-sdk/milestone/142

Commits
  • ee8ada3 chore(web-api): release @​slack/web-api@​7.9.1 (#2206)
  • e8e7b27 chore(deps-dev): bump typescript from 5.7.3 to 5.8.2 in /packages/oauth (#2162)
  • dfe6c0e chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/oauth in the d...
  • 5fe0b80 chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/socket-mode in...
  • eccb157 chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/web-api in the...
  • 0a754a3 chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/cli-hooks in t...
  • e35d1c3 chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/cli-test in th...
  • 6d68397 test(oauth): increase timeouts for file state store checks with multiple entr...
  • 1d58f47 chore(deps-dev): bump sinon from 19.0.5 to 20.0.0 in /packages/logger in the ...
  • 0903f5f fix(web-api): complete file upload v2 calls if absolute urls are not allowed ...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @zimeg.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 27, 2025
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (3c4cea1) to head (4499d7c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2473   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/slack/web-api-tw-7.9.1 branch from 9b822d8 to c6b59c1 Compare March 27, 2025 22:42
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/slack/web-api-tw-7.9.1 branch from c6b59c1 to 4499d7c Compare March 27, 2025 22:53
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot dependabot bot merged commit d941a44 into main Mar 27, 2025
18 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/slack/web-api-tw-7.9.1 branch March 27, 2025 22:55
@zimeg zimeg added this to the 4.3.0 milestone Mar 27, 2025
@zimeg
Copy link
Member

zimeg commented Mar 27, 2025

📝 Adding the semver:minor label to this since allowAbsoluteUrls becomes available to clientOptions, even if not available in types at the moment.

const app = new App({
  token: process.env.SLACK_BOT_TOKEN,
  appToken: process.env.SLACK_APP_TOKEN,
  socketMode: true,
  logLevel: LogLevel.DEBUG,
  clientOptions: {
    allowAbsoluteUrls: false,
  },
});

Noting this now, but I think a follow up PR is better for this. Of course, I am open to discussion on all of this 🙏 ✨

@zimeg
Copy link
Member

zimeg commented Mar 28, 2025

📝 The issue linked above - #2484 - suggests another approach to typed clientOptions of the App constructor to perhaps avoid similar issues in later releases of @slack/web-api- 🚀

@hello-ashleyintech hello-ashleyintech modified the milestones: 4.3.0, 4.2.2 May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants