Skip to content

Comments

ci: increase updated versions to depend on the latest releases#2468

Merged
zimeg merged 1 commit intomainfrom
zimeg-ci-dependabot-increase-versioning-strategy
Mar 27, 2025
Merged

ci: increase updated versions to depend on the latest releases#2468
zimeg merged 1 commit intomainfrom
zimeg-ci-dependabot-increase-versioning-strategy

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 27, 2025

Summary

This PR uses the "increase" versioning-strategy @dependabot has to match the latest upstream @slack dependencies 📦 ✨

Notes

This change is suggested after finding "dependabot only updates lock file" when started from the Insights tab AFAICT. If applied, I'm hoping we'll find these updates afterwards 👾

https://github.com/slackapi/bolt-js/actions/runs/14114557499/job/39541462306#step:3:1295:

updater | 2025/03/27 18:57:35 INFO <job_988067578> Started process PID: 1732 with command: {} npm install @slack/[email protected] --package-lock-only --dry-run\=true --ignore-scripts {}

I'm curious if keeping up-to-date with the latest @slack packages makes sense for @slack/bolt overall? I believe sometimes options are added upstream that we use here, so this might guarantee the latest @slack/bolt will be working with these. I'm not sure if other @slack dependencies are sometimes pinned to different versions in application code though.

IMO recommending the latest versions are used altogether does seem nice for avoiding strange edge cases overall...

Requirements

@zimeg zimeg added discussion M-T: An issue where more input is needed to reach a decision dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 27, 2025
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (4b5c361) to head (6682c6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 💯 lets see if it this resolves the issue

@zimeg
Copy link
Member Author

zimeg commented Mar 27, 2025

@hello-ashleyintech @WilliamBergamin Like y'all I am excited for these updates. Thank you for reviewing this! 🤖 ✨

@zimeg zimeg merged commit f430944 into main Mar 27, 2025
18 checks passed
@zimeg zimeg deleted the zimeg-ci-dependabot-increase-versioning-strategy branch March 27, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file discussion M-T: An issue where more input is needed to reach a decision github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants