Skip to content

Comments

fix: configure dependbot to group react deps#2440

Merged
WilliamBergamin merged 1 commit intomainfrom
group-react-deps-for-dependabot
Mar 3, 2025
Merged

fix: configure dependbot to group react deps#2440
WilliamBergamin merged 1 commit intomainfrom
group-react-deps-for-dependabot

Conversation

@WilliamBergamin
Copy link
Contributor

Summary

#2414 and #2413 are failing tests because dependabot is opening separate PR for react and react-dom dependencies, I believe these dependencies must stay in sync in order for the tests to pass.

Once this PR is merged dependabot should open one single PR to replace #2414 and #2413

Requirements (place an x in each [ ])

@WilliamBergamin WilliamBergamin added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 3, 2025
@WilliamBergamin WilliamBergamin self-assigned this Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (62a3018) to head (fbff51c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin WilliamBergamin requested a review from mwbrooks March 3, 2025 17:55
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Nice, thank you @WilliamBergamin

@WilliamBergamin WilliamBergamin merged commit c72754e into main Mar 3, 2025
18 checks passed
@WilliamBergamin WilliamBergamin deleted the group-react-deps-for-dependabot branch March 3, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants