bug: make @types/express a peer dependency#2421
Merged
WilliamBergamin merged 2 commits intomainfrom Feb 10, 2025
Merged
Conversation
WilliamBergamin
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
Feb 10, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM! Thanks for investigating the and finding this fix 🙏 ✨
I confirmed this fixes builds with typescript that don't include @types/express which is a super nice unblock 🪓
2 tasks
2 tasks
2 tasks
WilliamBergamin
changed the title
@types/express an optional peer dependency@types/express a peer dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This aims to resolve #2409
In #2355 we moved
@types/expressfromdependenciestodevDependencies, this made@types/expressnot installed in users projects. This PR aims to make@types/expressapeerDependency, peerDependencies are installed by default but developers can prevent the on disk installation of peer dependencies with the omit flagnpm install --omit peeror completely ignore the installation of peer dependencies with the legacy-peer-deps flagnpm install --legacy-peer-depsRequirements (place an
xin each[ ])