Skip to content

Comments

chore(deps-dev): bump @types/node from 18.19.71 to 22.10.7 in /examples/custom-receiver#2404

Merged
dependabot[bot] merged 1 commit intomainfrom
dependabot/npm_and_yarn/examples/custom-receiver/types/node-22.10.7
Jan 21, 2025
Merged

chore(deps-dev): bump @types/node from 18.19.71 to 22.10.7 in /examples/custom-receiver#2404
dependabot[bot] merged 1 commit intomainfrom
dependabot/npm_and_yarn/examples/custom-receiver/types/node-22.10.7

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps @types/node from 18.19.71 to 22.10.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (8dee403) to head (4278db0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin
Copy link
Contributor

This raises a good question around our examples dependencies 🤔
Should examples be using the minimum supported version of dependencies to show how this project supports these older dependencies or should it lead by example and use the latests versions?

@seratch if you have some time, I'd like to get your thoughts on this

@seratch
Copy link
Contributor

seratch commented Jan 21, 2025

@WilliamBergamin Thanks for raising this topic!

My opinion here is that we don't need to ensure the oldestest TS version compatibility using these examples. There are two reasons:

  1. Our CI builds can verify source code compatibilities with a few TS major versions; Having sufficient unit test code should detect breaking changes in newer major versions
  2. Developers will reuse any of these examples to start a new project, so we should encourage using the latest major TS version

@WilliamBergamin
Copy link
Contributor

@dependabot squash and merge

@dependabot dependabot bot merged commit da00f6c into main Jan 21, 2025
18 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/examples/custom-receiver/types/node-22.10.7 branch January 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants