docs(examples): fix the "deploy to heroku" button using latest dependencies#2385
docs(examples): fix the "deploy to heroku" button using latest dependencies#2385zimeg merged 19 commits intoslackapi:mainfrom
Conversation
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📝 Notes for the kind reviewers!
|
|
||
| ### 6. Bonus: Deploy to Heroku with one click | ||
|
|
||
| [](https://heroku.com/deploy?template=https://github.com/slackapi/bolt-js) |
There was a problem hiding this comment.
I think having this button in a subdirectory is causing strange redirects. It's replaced with the redirected result here, which I find to be working well 🙏
There was a problem hiding this comment.
This link worked for me 💯
There was a problem hiding this comment.
🤔 I'm finding that navigating directly to the link (that was removed) works, but clicking it from the following pages doesn't:
main: https://github.com/slackapi/bolt-js/blob/main/examples/deploy-heroku/README.md
fork: https://github.com/zimeg/bolt-js/blob/main/examples/deploy-heroku/README.md
| await app.start(process.env.PORT || 3000); | ||
|
|
||
| console.log('⚡️ Bolt app is running!'); | ||
| app.logger.info('⚡️ Bolt app is running!'); |
There was a problem hiding this comment.
🔍 From the logs!
2025-01-08T18:18:40.258427+00:00 heroku[web.1]: Starting process with command `node app.js`
2025-01-08T18:18:40.933034+00:00 app[web.1]: [INFO] bolt-app ⚡️ Bolt app is running!
2025-01-08T18:18:41.379963+00:00 heroku[web.1]: State changed from starting to up
| "web": { | ||
| "quantity": 1, | ||
| "size": "free" | ||
| "size": "eco" |
There was a problem hiding this comment.
The free tier is no longer an option and caused errors on setup - https://www.heroku.com/pricing
| "features": { | ||
| "bot_user": { | ||
| "display_name": "Bolt on Heroku Example", | ||
| "always_online": true |
There was a problem hiding this comment.
Related to the eco dyno that can sleep - I think it's alright to suppose the bot is always online. It just might be slow to response 🤔
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice job these changes look good 💯
I did not test the deployment first hand, but trust you have!
|
|
||
| ### 6. Bonus: Deploy to Heroku with one click | ||
|
|
||
| [](https://heroku.com/deploy?template=https://github.com/slackapi/bolt-js) |
There was a problem hiding this comment.
This link worked for me 💯
|
@WilliamBergamin 🙏 Thanks for reviewing! I've tested this a few times and am feeling confident with the setup for now, but will confirm things are working after merging 🚢 💨 |
2 participants
Summary
This PR checks out the
herokuexample of a Bolt JS app and smoothes edges found when testing!Reviewers
These changes are available on this forked branch: zimeg/bolt-js/tree/main/examples/deploy-heroku
The "Deploy to Heroku" button at the end links to slackapi/bolt-js - the following link can be used to test these changes: https://dashboard.heroku.com/new?template=https://github.com/zimeg/bolt-js
The included manifest can be used to create a Slack app for the bot token and signing secret 🔒
Requirements