docs: nested sidebar format#2374
Merged
lukegalbraithrussell merged 1 commit intomainfrom Dec 19, 2024
Merged
Conversation
| label: 'Bolt for JavaScript', | ||
| className: 'sidebar-title', | ||
| }, | ||
| 'getting-started', |
Contributor
Author
There was a problem hiding this comment.
uh i just added an extra <hr> here
| type: 'category', | ||
| label: 'App Configuration', | ||
| label: 'Guides', | ||
| collapsed: false, |
Contributor
Author
There was a problem hiding this comment.
and this is new, too. Everything else is github not understanding what's going on. it is the same!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
technically-tracy
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a slightly smaller font for the sidebar, this gives us some more room to place with spacing. This places all the guides in a uncollapsed "guides" category, to match the deno slack sdk docs format: https://tools.slack.dev/deno-slack-sdk/
It fixes the bolding issues that currently exists because the css was focused on the deno slack sdk docs
This will be important as we look into building out reference docs (as they can all live under a nice "reference" folder)
Requirements (place an
xin each[ ])