Skip to content

Comments

docs: nested sidebar format#2374

Merged
lukegalbraithrussell merged 1 commit intomainfrom
docs-new-nested-sidebar-format
Dec 19, 2024
Merged

docs: nested sidebar format#2374
lukegalbraithrussell merged 1 commit intomainfrom
docs-new-nested-sidebar-format

Conversation

@lukegalbraithrussell
Copy link
Contributor

Summary

With a slightly smaller font for the sidebar, this gives us some more room to place with spacing. This places all the guides in a uncollapsed "guides" category, to match the deno slack sdk docs format: https://tools.slack.dev/deno-slack-sdk/

It fixes the bolding issues that currently exists because the css was focused on the deno slack sdk docs

This will be important as we look into building out reference docs (as they can all live under a nice "reference" folder)

Requirements (place an x in each [ ])

label: 'Bolt for JavaScript',
className: 'sidebar-title',
},
'getting-started',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh i just added an extra <hr> here

type: 'category',
label: 'App Configuration',
label: 'Guides',
collapsed: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is new, too. Everything else is github not understanding what's going on. it is the same!

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (57add31) to head (db9ab3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell merged commit f2eaae7 into main Dec 19, 2024
@lukegalbraithrussell lukegalbraithrussell deleted the docs-new-nested-sidebar-format branch December 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants