Skip to content

Comments

build: ignore autogenerated docusaurus files when running the formatter#2362

Merged
zimeg merged 3 commits intomainfrom
zimeg-build-ignore-autogen-docs-lint
Dec 11, 2024
Merged

build: ignore autogenerated docusaurus files when running the formatter#2362
zimeg merged 3 commits intomainfrom
zimeg-build-ignore-autogen-docs-lint

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Dec 11, 2024

Summary

This PR replaces docs/_site with docs/.docusaurus as an ignored path of biome lintings 🌲 🙏 ✨

Fixes a broken npm run lint in the project root that appears after building the documentation! 📚

Reviewers

Checkout these changes and make sure no unexpected linting errors appear:

$ cd bolt-js
$ npm install
$ npm run lint
$ cd docs
$ npm install
$ npm start
$ cd ..
$ npm run lint  # No more errors should appear here!

Requirements

@zimeg zimeg added this to the 4.1.2 milestone Dec 11, 2024
@zimeg zimeg requested review from a team and lukegalbraithrussell December 11, 2024 00:58
@zimeg zimeg self-assigned this Dec 11, 2024
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (cff0f2d) to head (6915bb5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zimeg
Copy link
Member Author

zimeg commented Dec 11, 2024

@lukegalbraithrussell 🙏 ✨ thanks - with formatting!

@zimeg zimeg merged commit 34b93ab into main Dec 11, 2024
@zimeg zimeg deleted the zimeg-build-ignore-autogen-docs-lint branch December 11, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants