build: install @types/express@^v5 as a dev dependency for express@^5#2355
build: install @types/express@^v5 as a dev dependency for express@^5#2355
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
It's curious that @dependabot didn't catch this in the last round of updates... We seem to include just a handful of dependencies in this list, but I'm wondering if we want to revisit this? |
|
@zimeg Yeah, we can add more dependencies to the list. At least, having |
|
@seratch Thanks! And adding some dependencies sounds good. 🚀 It makes sense that A combination of options for Hoping to explore this more after thinking about versions a bit, but I'd love to know if you have immediate thoughts on these numbers 🙏 |
Summary
This PR bumps
@types/expressto v5 to match the includedexpressv5 package. These typings are also moved into thedevDependenciessince these are required for just the build step AFAIK! Fixes #2354.Requirements