Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 36 36
Lines 7472 7472
Branches 651 651
=======================================
Hits 6911 6911
Misses 553 553
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kuredev
force-pushed
the
add_xapp_section-getting-started-ja
branch
2 times, most recently
from
a48bbbb to
5017edc
Compare
kuredev
force-pushed
the
add_xapp_section-getting-started-ja
branch
from
5017edc to
c47726f
Compare
seratch
suggested changes
Nov 19, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thank you so much for taking the time to improve the docuement! May I ask you to work on the HTTP tab too?
| </TabItem> | ||
| <TabItem value="http" label="HTTP"> | ||
|
|
||
| 作業中です！ |
Contributor
There was a problem hiding this comment.
If you don't mind, can I ask you to work on this too?
Contributor
Author
kuredev
force-pushed
the
add_xapp_section-getting-started-ja
branch
from
c82ce80 to
13a72bf
Compare
seratch
reviewed
Nov 19, 2024
docs/i18n/ja-jp/docusaurus-plugin-content-docs/current/getting-started.mdx
Outdated
Show resolved
Hide resolved
seratch
approved these changes
Nov 19, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
LGTM; Thank you so much for taking the time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added an explanation about saving a certain environment variable to the Japanese documentation since it was mentioned in the English documentation but not in the Japanese one.
en
ja
Requirements (place an
xin each[ ])