Skip to content

Comments

Docs: Changed "App Token" to "App-Level Tokens"#2336

Merged
filmaj merged 1 commit intoslackapi:mainfrom
kuredev:docs-fix-basic-information
Nov 18, 2024
Merged

Docs: Changed "App Token" to "App-Level Tokens"#2336
filmaj merged 1 commit intoslackapi:mainfrom
kuredev:docs-fix-basic-information

Conversation

@kuredev
Copy link
Contributor

@kuredev kuredev commented Nov 15, 2024

Summary

I propose a correction to the "Getting started with Bolt for JavaScript" documentation because some parts use expressions that differ from the actual wording in Slack's settings screen.

https://tools.slack.dev/bolt-js/ja-jp/getting-started/
https://tools.slack.dev/bolt-js/getting-started/

Slack Settings Screen

https://api.slack.com/apps/xxxxxxx/general

image

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @kuredev to sign the Salesforce Inc. Contributor License Agreement.

@kuredev kuredev force-pushed the docs-fix-basic-information branch from 6968c91 to f178e80 Compare November 15, 2024 15:15
@kuredev kuredev force-pushed the docs-fix-basic-information branch from 2de7931 to 274863c Compare November 15, 2024 15:22
@kuredev kuredev marked this pull request as ready for review November 15, 2024 15:23
@filmaj filmaj added the docs M-T: Documentation work only label Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (248663d) to head (274863c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      651      651           
=======================================
  Hits         6911     6911           
  Misses        553      553           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filmaj
Copy link
Contributor

filmaj commented Nov 18, 2024

Thank you for the improvement!

@filmaj filmaj merged commit 7020a2e into slackapi:main Nov 18, 2024
@kuredev kuredev deleted the docs-fix-basic-information branch November 19, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants