Merged
Conversation
mwbrooks
requested changes
Oct 2, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
🙇🏻 Thanks so much for putting up this PR!
📝 Quick change request is that we'll need to also update the chat_startStream references in listeners/events/app_mentioned.py
mwbrooks
changed the title
mwbrooks
approved these changes
Oct 2, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks for putting together this PR! 🎉
🧪 Manual testing working for DM, mentions, and assistant threads.
Comment on lines
+128
to
+129
| # Loop over OpenAI response stream | ||
| # https://platform.openai.com/docs/api-reference/responses/create |
Member
There was a problem hiding this comment.
I added commit 15d6bce to keep the comments consistent between the assistant and app_mention files.
Comment on lines
+37
to
+41
| streamer = client.chat_stream( | ||
| channel=channel_id, | ||
| recipient_team_id=team_id, | ||
| recipient_user_id=user_id, | ||
| thread_ts=thread_ts, |
Member
There was a problem hiding this comment.
praise: Thanks @srtaalej for improving this formatting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
adds new streaming helper
Requirements