Add support for title argument in CreateChannelCanvas method#1483
Merged
Conversation
Member
|
Hi @jarospisak-unity. As it stands this is a breaking change and I'd rather not add breaking changes if they can be avoided at all. One way is simply to add a method that allows to pass options. This pattern already exists in other parts of the codebase. Happy for you to give it a go if you're ok to do so, alternatively, I'll come back to this soon-ish. |
Contributor
Author
|
@nlopes thanks for the feedback, I wasn't aware of that pattern. I'll refactor this pull request. |
7b0a59f to
cc6e18e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
titleargument in theCreateChannelCanvasmethod.Closes #1482.