feat: Align GetReactions with Slack API#1480
Merged
Merged
Conversation
4 tasks
9808e43 to
d27ef61
Compare
nlopes
approved these changes
Nov 5, 2025
d27ef61 to
8870d8e
Compare
!BREAKING CHANGE Previously this method returned only reaction details, but with this change it started to also return the item itself (e.g. message, file, file_comment). This makes this closer to the actual response of Slack API. To migrate an existing code, you can just use resp.Reactions to access the slice of []ItemReaction.
8870d8e to
b4fa961
Compare
I think the Slack API returns the channel field at the root level of the reactions.get response for message types, not inside the message object.
1fde67c to
5a50289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this method returned only reaction details, but with this change it started to also return the item itself (e.g.
message,file,file_comment). This makes this closer to the actual response of the Slack API.To migrate an existing code, you can just use
resp.Reactionsto access the slice of[]ItemReaction.API changes
GetReactionsreturnsReactedIteminstead of the[]ItemReaction. To migrate your existing logic, you can switch to usingresp.ReactionsCloses #1479