feat: add cursor-based pagination support for user retrieval#1465
Merged
nlopes merged 1 commit intoSep 14, 2025
Conversation
KamikazeZirou
force-pushed
the
feature/GetUsers-With-Cursor
branch
from
7e46e30 to
6a5d641
Compare
KamikazeZirou
force-pushed
the
feature/GetUsers-With-Cursor
branch
from
6a5d641 to
ec61ba9
Compare
Replace ResponseMetadata-based pagination with direct cursor handling in UserPagination struct. This simplifies the pagination logic and provides more explicit control over cursor state. Changes: - Add GetUsersOptionCursor() to set pagination cursor - Replace previousResp field with Cursor and complete fields - Update Next() method to use cursor directly from API response - Add test coverage for cursor-based pagination scenarios
KamikazeZirou
force-pushed
the
feature/GetUsers-With-Cursor
branch
from
ec61ba9 to
bbf9c45
Compare
nlopes
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1468
Summary of changes
GetUsersOptionCursoras aGetUsersOptionto specify the cursor ofusers.listCursortoUserPaginationto return the next page cursor to SDK clients afterusers.listPull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prepfrom the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: