Skip to content

support Data Access API#1439

Merged
nlopes merged 6 commits into
slack-go:masterfrom
nktks:data-access-api
Sep 14, 2025
Merged

support Data Access API#1439
nlopes merged 6 commits into
slack-go:masterfrom
nktks:data-access-api

Conversation

@nktks

@nktks nktks commented Jun 4, 2025

Copy link
Copy Markdown
Contributor
Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

@nlopes nlopes self-assigned this Jun 5, 2025
@nlopes

nlopes commented Jun 5, 2025

Copy link
Copy Markdown
Member

@nktks I'm not going to review this until you move it into ready for review - just wanted to call that out explicitly. Thanks for adding this.

@nlopes nlopes self-requested a review June 28, 2025 13:52
@nlopes

nlopes commented Jun 28, 2025

Copy link
Copy Markdown
Member

@nktks just checking in on this - no pressure at all but want to make sure you didn't just leave it at Draft by mistake 🙏

@nktks

nktks commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

@nlopes Sorry for the confusion.
I've requested for the Data Access API to Slack, but it hasn't been approved yet for long time, so I'm still waiting....
Because of this, I haven't been able to test it....

@nlopes

nlopes commented Jul 4, 2025

Copy link
Copy Markdown
Member

Ah if that's the part that's missing, I can test it for you, no problem at all.

Realised that developer sandbox environments don't have this enabled :(

@nktks

nktks commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

@nktks nktks marked this pull request as ready for review July 9, 2025 10:50
@nktks

nktks commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

@nlopes Hello.
Our app was approved and I could test thorough https://github.com/slack-go/slack/pull/1439/files#diff-03269bab64cd2cd7188b80de22221ee1321f6ee37f70d909a40e67205b724c24 .

So I changed as ready for review this PR.
Could you please take a look when you have time?


// Handle a specific event from EventsAPI
socketmodeHandler.HandleEvents(slackevents.AppMention, middlewareAppMentionEvent)
socketmodeHandler.HandleEvents(slackevents.Message, middlewareMessageEvent)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if this was an example on its own. That's to make sure that people that don't have this API yet, won't be affected if they want to run this example (basically it will save me answering queries about why this example might not be working).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.
I divided the exapmle.

d4221e7
e044f7a

@nktks nktks requested a review from nlopes July 13, 2025 08:49
@nlopes nlopes merged commit 282467b into slack-go:master Sep 14, 2025
4 checks passed
@nktks nktks deleted the data-access-api branch September 24, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants