Description
The Skype field in UserProfile struct (users.go) has an incorrect JSON tag "skyp" instead of "skype".
https://github.com/slack-go/slack/blob/master/users.go#L28
Skype string `json:"skyp,omitempty"`
This means the field is never properly populated when unmarshalling Slack API responses, as the API returns "skype" as the key.
The correct tag "skype" is already used in slackevents/inner_events.go:
https://github.com/slack-go/slack/blob/master/slackevents/inner_events.go#L1103
Expected behavior
The JSON tag should be "skype" to match the Slack API response format.
Slack's documentation
https://docs.slack.dev/reference/objects/user-object
profile.skype - Shadow from a bygone era. Always an empty string.
I'm planning to work on this fix.
Description
The
Skypefield inUserProfilestruct (users.go) has an incorrect JSON tag"skyp"instead of"skype".https://github.com/slack-go/slack/blob/master/users.go#L28
This means the field is never properly populated when unmarshalling Slack API responses, as the API returns
"skype"as the key.The correct tag
"skype"is already used inslackevents/inner_events.go:https://github.com/slack-go/slack/blob/master/slackevents/inner_events.go#L1103
Expected behavior
The JSON tag should be
"skype"to match the Slack API response format.Slack's documentation
https://docs.slack.dev/reference/objects/user-object
I'm planning to work on this fix.