Repository navigation
Commit 11eb9d3
authored
refactor: decode block values directly (#1699)
Decode composition objects, accessories, and context elements directly
into concrete pointers. Remove two helpers that returned their input as
an interface, 19 redundant type assertions, and the unused private
interface and marker methods. This removes 48 lines.
Preserve decoded values, error handling, and assignment only after
successful decoding. Public types and APIs remain unchanged.
Validation: existing block, accessory, composition-object, and Slack
icon tests pass, along with formatting, lint, module, and whitespace
checks. A temporary comparison against the original implementation
produced identical decoded state, error types, and error messages across
3,582 cases, including nulls, malformed fields, unknown types, prefilled
receivers, and partial failures.1 parent 68d04de commit 11eb9d3
2 files changed
Lines changed: 58 additions & 106 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
312 | | - | |
| 311 | + | |
| 312 | + | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
| 315 | + | |
316 | 316 | | |
317 | | - | |
318 | | - | |
| 317 | + | |
| 318 | + | |
319 | 319 | | |
320 | 320 | | |
321 | | - | |
| 321 | + | |
322 | 322 | | |
323 | | - | |
324 | | - | |
| 323 | + | |
| 324 | + | |
325 | 325 | | |
326 | 326 | | |
327 | | - | |
| 327 | + | |
328 | 328 | | |
329 | | - | |
330 | | - | |
| 329 | + | |
| 330 | + | |
331 | 331 | | |
332 | 332 | | |
333 | | - | |
| 333 | + | |
334 | 334 | | |
335 | | - | |
336 | | - | |
| 335 | + | |
| 336 | + | |
337 | 337 | | |
338 | 338 | | |
339 | | - | |
| 339 | + | |
340 | 340 | | |
341 | | - | |
342 | | - | |
| 341 | + | |
| 342 | + | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
346 | 346 | | |
347 | | - | |
348 | | - | |
| 347 | + | |
| 348 | + | |
349 | 349 | | |
350 | 350 | | |
351 | | - | |
| 351 | + | |
352 | 352 | | |
353 | | - | |
354 | | - | |
| 353 | + | |
| 354 | + | |
355 | 355 | | |
356 | 356 | | |
357 | | - | |
| 357 | + | |
358 | 358 | | |
359 | | - | |
360 | | - | |
| 359 | + | |
| 360 | + | |
361 | 361 | | |
362 | 362 | | |
363 | | - | |
| 363 | + | |
364 | 364 | | |
365 | | - | |
366 | | - | |
| 365 | + | |
| 366 | + | |
367 | 367 | | |
368 | 368 | | |
369 | | - | |
| 369 | + | |
370 | 370 | | |
371 | | - | |
372 | | - | |
| 371 | + | |
| 372 | + | |
373 | 373 | | |
374 | 374 | | |
375 | | - | |
| 375 | + | |
376 | 376 | | |
377 | | - | |
378 | | - | |
| 377 | + | |
| 378 | + | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
| 381 | + | |
382 | 382 | | |
383 | | - | |
384 | | - | |
| 383 | + | |
| 384 | + | |
385 | 385 | | |
386 | 386 | | |
387 | | - | |
| 387 | + | |
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | 393 | | |
402 | 394 | | |
403 | 395 | | |
| |||
472 | 464 | | |
473 | 465 | | |
474 | 466 | | |
475 | | - | |
476 | | - | |
| 467 | + | |
| 468 | + | |
477 | 469 | | |
478 | 470 | | |
479 | 471 | | |
480 | | - | |
| 472 | + | |
481 | 473 | | |
482 | | - | |
483 | | - | |
| 474 | + | |
| 475 | + | |
484 | 476 | | |
485 | 477 | | |
486 | 478 | | |
487 | | - | |
| 479 | + | |
488 | 480 | | |
489 | 481 | | |
490 | 482 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | 13 | | |
17 | 14 | | |
18 | 15 | | |
| |||
26 | 23 | | |
27 | 24 | | |
28 | 25 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | 26 | | |
34 | 27 | | |
35 | 28 | | |
| |||
57 | 50 | | |
58 | 51 | | |
59 | 52 | | |
60 | | - | |
61 | | - | |
| 53 | + | |
| 54 | + | |
62 | 55 | | |
63 | 56 | | |
64 | | - | |
| 57 | + | |
65 | 58 | | |
66 | | - | |
67 | | - | |
| 59 | + | |
| 60 | + | |
68 | 61 | | |
69 | 62 | | |
70 | | - | |
| 63 | + | |
71 | 64 | | |
72 | | - | |
73 | | - | |
| 65 | + | |
| 66 | + | |
74 | 67 | | |
75 | 68 | | |
76 | | - | |
| 69 | + | |
77 | 70 | | |
78 | | - | |
79 | | - | |
| 71 | + | |
| 72 | + | |
80 | 73 | | |
81 | 74 | | |
82 | | - | |
| 75 | + | |
83 | 76 | | |
84 | 77 | | |
85 | 78 | | |
| |||
108 | 101 | | |
109 | 102 | | |
110 | 103 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | 104 | | |
120 | 105 | | |
121 | 106 | | |
| |||
126 | 111 | | |
127 | 112 | | |
128 | 113 | | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
| 114 | + | |
135 | 115 | | |
136 | 116 | | |
137 | 117 | | |
| |||
207 | 187 | | |
208 | 188 | | |
209 | 189 | | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | 190 | | |
216 | 191 | | |
217 | 192 | | |
| |||
247 | 222 | | |
248 | 223 | | |
249 | 224 | | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | 225 | | |
256 | 226 | | |
257 | 227 | | |
| |||
260 | 230 | | |
261 | 231 | | |
262 | 232 | | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | 233 | | |
269 | 234 | | |
270 | 235 | | |
| |||
283 | 248 | | |
284 | 249 | | |
285 | 250 | | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | 251 | | |
292 | 252 | | |
293 | 253 | | |
| |||
0 commit comments