Skip to content

Commit f9afd42

Browse files
committed
docs(plan): record 2026-08-27 progress — posted modelcontextprotocol#1089/modelcontextprotocol#990 comments, A2 implemented on fork branch
1 parent fff068c commit f9afd42

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎PLAN-2026-07-28.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ Supersedes the first draft. Every issue/PR reference below was checked against G
44

55
Amended 2026-08-27: corrected SEP-2106 status — `Tool.outputSchema` and 2020-12 validation are already implemented in this codebase; A5 reworded from "new PR" to audit + narrow follow-up (A2 remains the suggested first PR). Draft #1089 comment trimmed.
66

7+
**Progress log (2026-08-27):** posted the #1089 design-review comment ([#issuecomment-5432016937](https://github.com/modelcontextprotocol/java-sdk/pull/1089#issuecomment-5432016937)) and the #990 SEP-2243 consolidation proposal ([#issuecomment-5432017089](https://github.com/modelcontextprotocol/java-sdk/issues/990#issuecomment-5432017089)); edited the latter to correct the Spring-transport claim after a diff audit showed all three ORs touch only `mcp-core`. A2 implementation completed on fork branch `feat/sep-2243-headers` (client emission + servlet validation + tests + docs; see the A2/§8 status notes). Remaining before opening the A2 PR: server-side validation tests (needs servlet harness) and coordination with #994/#1026/#1092 authors once #990 settles.
8+
79
## 0. The governing constraint
810

911
Before any technical content: the core transport work is **closed to outside contribution**.
@@ -101,6 +103,8 @@ What is not: `extensions` map, `ttlMs`/`cacheScope`, `@Deprecated` annotations,
101103

102104
**A2. SEP-2243 — consolidate three PRs.** #994 (Mcp-Name), #1026 (Mcp-Method), #1092 (protocol-version validation) overlap and none has full coverage. Propose on #990 a single PR that: emits `Mcp-Method` on every streamable-HTTP client POST and `Mcp-Name` on tools/call, prompts/get, resources/read/subscribe/unsubscribe across `HttpClientStreamableHttpTransport` and the Spring/WebClient transports; adds server-side validation as **opt-in** (`rejectMissingHeaders(false)` default, mismatch-with-body always rejected); tests per transport. Coordinate with the three authors first — this is etiquette, not optional. Size M.
103105

106+
> **Status 2026-08-27 — implementation done on branch `feat/sep-2243-headers` (fork, no PR yet).** Corrections that supersede the text above: there are **no separate Spring/WebClient streamable-HTTP transports in 2.x** — all three ORs live in `mcp-core`. Client emission verified (`Mcp-Method` on every POST; `Mcp-Name` on tools/call, prompts/get, resources/read/subscribe/unsubscribe — closing #994's missing subscribe/unsubscribe). Server validation landed on the servlet transports with the corrected semantics (present-but-mismatched header always rejected; absent tolerated for legacy clients — this replaces the originally proposed `rejectMissingHeaders` opt-in flag, which would have wrongly gated mismatches too). Tests: `Sep2243ClientRequestHeaderTests` (jdk-http client emission) pass; server-side validation tests still TODO (need servlet harness). Docs updated (client.md, server.md). Commits `9403d91c..f9988345`.
107+
104108
**A3. SEP-2549 — review and extend #1062.** Schema side is there. Follow-up PR: client-side cache keyed by list result, invalidated on `*/list_changed`. Also serves #1089 D6 (the modern client needs a tool-definition cache for header mirroring anyway). Size M.
105109

106110
**A4. SEP-2577 — review #1053.** Annotations only. Confirm Javadoc `@deprecated` points to the replacement pattern (tool args for roots, direct provider call for sampling, OTel/stderr for logging) and that HTTP+SSE transport classes and DCR helpers get the same treatment — the SEP deprecates those too and #1053 may not cover them. Size S.
@@ -176,4 +180,6 @@ docs: SEP-2243 section in transport docs
176180
Closes #990. Supersedes #994, #1026, #1092 (with credit).
177181
```
178182

183+
> **Status 2026-08-27:** this is now **implemented on the fork branch** (no PR yet). Fundamentally the plan above as written. Note two deviations from the commit plan text: (1) the "spring-webclient, webmvc, webflux" test matrix is moot in 2.x — no such transports exist; all ORs touched `mcp-core`. (2) Server validation uses mismatch-rejected / absent-tolerated semantics, not an `rejectMissingHeaders` opt-in flag.
184+
179185
If the authors object to consolidation, fall back to A6 (SEP-2352 / SEP-2468 auth) — genuinely no PRs exist for those. A5 (SEP-2106) is no longer a good fallback: per the A5 correction it's an audit-sized item, not a feature PR.

0 commit comments

Comments
 (0)