Repository navigation
[ENH] Add second PAA test parameter set - #10231
Merged
Merged
Conversation
snoopuppy582
requested review from
SimonBlanke,
benHeid,
felipeangelimvieira,
fkiraly,
geetu040,
jgyasu,
marrov and
yarnabrina
as code owners
May 11, 2026 23:35
snoopuppy582
force-pushed
the
enh/paa-test-params-3429
branch
from
June 18, 2026 22:27
149bd45 to
ce91877
Compare
Contributor
Author
|
Closing this because #10489 has since merged the same PAA test-parameter coverage change and exclusion removal. |
fkiraly
added
module:transformations
fkiraly
approved these changes
Jul 16, 2026
fkiraly
left a comment
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Ah, apologies - you were first, so you should get some credit. I will also merge this for the credit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM generated content, by GPT-5
Reference Issues/PRs
Part of #3429.
What does this implement/fix? Explain your changes.
This adds a second lightweight test parameter set for
PAAusing theframe_sizecode path, then removesPAAfromtest_get_test_params_coverageexclusions.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
{"frame_size": 4}is an appropriate second lightweight parameter set forPAA.Did you add any tests for the change?
This updates
get_test_params, which is exercised by the existing estimator test suite.Local checks:
TestAllObjects().run_tests(PAA, tests_to_run="test_get_test_params_coverage")passedTestAllObjects().run_tests(PAA)passed with 57 checks and 0 failurespython -m ruff check sktime/transformations/series/paa.py sktime/tests/_config.pypassedAny other comments?
Kept this PR limited to
PAAonly.PR checklist
For all contributions
maintainerstag.