Simplify math_1, like other functions

skirpichev · skirpichev · commit 9c32ae022f07 · 2023-04-08T07:29:19.000+03:00
Now exception messages kept in is_error().  This improve
coverage for L1007.
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
@@ -990,24 +990,16 @@ math_1(PyObject *arg, double (*func) (double), int can_overflow)
         return NULL;
     errno = 0;
     r = (*func)(x);
-    if (Py_IS_NAN(r) && !Py_IS_NAN(x)) {
-        PyErr_SetString(PyExc_ValueError,
-                        "math domain error"); /* invalid arg */
-        return NULL;
-    }
+    if (Py_IS_NAN(r) && !Py_IS_NAN(x))
+        errno = EDOM;
     if (Py_IS_INFINITY(r) && Py_IS_FINITE(x)) {
         if (can_overflow)
-            PyErr_SetString(PyExc_OverflowError,
-                            "math range error"); /* overflow */
+            errno = ERANGE;
         else
-            PyErr_SetString(PyExc_ValueError,
-                            "math domain error"); /* singularity */
-        return NULL;
+            errno = EDOM;
     }
-    if (Py_IS_FINITE(r) && errno && is_error(r))
-        /* this branch unnecessary on most platforms */
+    if (errno && is_error(r))
         return NULL;
-
     return PyFloat_FromDouble(r);
 }
 
