Replace FIXMEs with TODOs

ben-clayton · ben-clayton · commit 5e9441a25484 · 2019-05-24T15:06:52.000Z
As requested here: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31841/1#message-24da63454b89e5d545f3b686f2470c8d2392ee61 Change-Id: I76500807933b565fb13f30268c47c7caa4be7c69 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31843 Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
diff --git a/src/Device/Blitter.cpp b/src/Device/Blitter.cpp
@@ -1297,7 +1297,7 @@ namespace sw
 		Int4 linear = CmpLT(c, Float4(0.04045f));
 
 		Float4 s = c;
-		s.xyz = As<Float4>((linear & As<Int4>(lc)) | (~linear & As<Int4>(ec)));   // FIXME: IfThenElse()
+		s.xyz = As<Float4>((linear & As<Int4>(lc)) | (~linear & As<Int4>(ec)));   // TODO: IfThenElse()
 
 		return s;
 	}
diff --git a/src/Pipeline/SamplerCore.cpp b/src/Pipeline/SamplerCore.cpp
@@ -2195,7 +2195,7 @@ namespace sw
 				default:   // Wrap
 					{
 						Int4 under = CmpLT(xyz0, Int4(0));
-						xyz0 = (under & maxXYZ) | (~under & xyz0);   // xyz < 0 ? dim - 1 : xyz   // FIXME: IfThenElse()
+						xyz0 = (under & maxXYZ) | (~under & xyz0);   // xyz < 0 ? dim - 1 : xyz   // TODO: IfThenElse()
 
 						Int4 nover = CmpLT(xyz1, dim);
 						xyz1 = nover & xyz1;   // xyz >= dim ? 0 : xyz
diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
@@ -275,7 +275,7 @@ namespace
 		sw::SIMD::Int linear = CmpLT(c, sw::SIMD::Float(0.04045f));
 
 		sw::SIMD::Float s = c;
-		s.xyz = rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) | (~linear & rr::As<sw::SIMD::Int>(ec)));   // FIXME: IfThenElse()
+		s.xyz = rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) | (~linear & rr::As<sw::SIMD::Int>(ec)));   // TODO: IfThenElse()
 
 		return s;
 	}
@@ -3486,7 +3486,7 @@ namespace sw
 		for (auto i = 0u; i < type.sizeInComponents; i++)
 		{
 			auto sel = cond.Int(condIsScalar ? 0 : i);
-			dst.move(i, (sel & lhs.Int(i)) | (~sel & rhs.Int(i)));   // FIXME: IfThenElse()
+			dst.move(i, (sel & lhs.Int(i)) | (~sel & rhs.Int(i)));   // TODO: IfThenElse()
 		}
 
 		return EmitResult::Continue;
diff --git a/src/Renderer/Blitter.cpp b/src/Renderer/Blitter.cpp
@@ -1174,7 +1174,7 @@ namespace sw
 		Int4 linear = CmpLT(c, Float4(0.04045f));
 
 		Float4 s = c;
-		s.xyz = As<Float4>((linear & As<Int4>(lc)) | (~linear & As<Int4>(ec)));   // FIXME: IfThenElse()
+		s.xyz = As<Float4>((linear & As<Int4>(lc)) | (~linear & As<Int4>(ec)));   // TODO: IfThenElse()
 
 		return s;
 	}
diff --git a/src/Shader/SamplerCore.cpp b/src/Shader/SamplerCore.cpp
@@ -2481,7 +2481,7 @@ namespace sw
 				default:   // Wrap
 					{
 						Int4 under = CmpLT(xyz0, Int4(0));
-						xyz0 = (under & maxXYZ) | (~under & xyz0);   // xyz < 0 ? dim - 1 : xyz   // FIXME: IfThenElse()
+						xyz0 = (under & maxXYZ) | (~under & xyz0);   // xyz < 0 ? dim - 1 : xyz   // TODO: IfThenElse()
 
 						Int4 nover = CmpLT(xyz1, dim);
 						xyz1 = nover & xyz1;   // xyz >= dim ? 0 : xyz

Original file line number	Diff line number	Diff line change
`@@ -1297,7 +1297,7 @@ namespace sw`
`1297`	`1297`	`Int4 linear = CmpLT(c, Float4(0.04045f));`
`1298`	`1298`
`1299`	`1299`	`Float4 s = c;`
`1300`		`- s.xyz = As<Float4>((linear & As<Int4>(lc)) \| (~linear & As<Int4>(ec))); // FIXME: IfThenElse()`
	`1300`	`+ s.xyz = As<Float4>((linear & As<Int4>(lc)) \| (~linear & As<Int4>(ec))); // TODO: IfThenElse()`
`1301`	`1301`
`1302`	`1302`	`return s;`
`1303`	`1303`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2195,7 +2195,7 @@ namespace sw`
`2195`	`2195`	`default: // Wrap`
`2196`	`2196`	`{`
`2197`	`2197`	`Int4 under = CmpLT(xyz0, Int4(0));`
`2198`		`- xyz0 = (under & maxXYZ) \| (~under & xyz0); // xyz < 0 ? dim - 1 : xyz // FIXME: IfThenElse()`
	`2198`	`+ xyz0 = (under & maxXYZ) \| (~under & xyz0); // xyz < 0 ? dim - 1 : xyz // TODO: IfThenElse()`
`2199`	`2199`
`2200`	`2200`	`Int4 nover = CmpLT(xyz1, dim);`
`2201`	`2201`	`xyz1 = nover & xyz1; // xyz >= dim ? 0 : xyz`
Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ namespace`
`275`	`275`	`sw::SIMD::Int linear = CmpLT(c, sw::SIMD::Float(0.04045f));`
`276`	`276`
`277`	`277`	`sw::SIMD::Float s = c;`
`278`		`- s.xyz = rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) \| (~linear & rr::As<sw::SIMD::Int>(ec))); // FIXME: IfThenElse()`
	`278`	`+ s.xyz = rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) \| (~linear & rr::As<sw::SIMD::Int>(ec))); // TODO: IfThenElse()`
`279`	`279`
`280`	`280`	`return s;`
`281`	`281`	`}`
`@@ -3486,7 +3486,7 @@ namespace sw`
`3486`	`3486`	`for (auto i = 0u; i < type.sizeInComponents; i++)`
`3487`	`3487`	`{`
`3488`	`3488`	`auto sel = cond.Int(condIsScalar ? 0 : i);`
`3489`		`- dst.move(i, (sel & lhs.Int(i)) \| (~sel & rhs.Int(i))); // FIXME: IfThenElse()`
	`3489`	`+ dst.move(i, (sel & lhs.Int(i)) \| (~sel & rhs.Int(i))); // TODO: IfThenElse()`
`3490`	`3490`	`}`
`3491`	`3491`
`3492`	`3492`	`return EmitResult::Continue;`
Original file line number	Diff line number	Diff line change
`@@ -1174,7 +1174,7 @@ namespace sw`
`1174`	`1174`	`Int4 linear = CmpLT(c, Float4(0.04045f));`
`1175`	`1175`
`1176`	`1176`	`Float4 s = c;`
`1177`		`- s.xyz = As<Float4>((linear & As<Int4>(lc)) \| (~linear & As<Int4>(ec))); // FIXME: IfThenElse()`
	`1177`	`+ s.xyz = As<Float4>((linear & As<Int4>(lc)) \| (~linear & As<Int4>(ec))); // TODO: IfThenElse()`
`1178`	`1178`
`1179`	`1179`	`return s;`
`1180`	`1180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2481,7 +2481,7 @@ namespace sw`
`2481`	`2481`	`default: // Wrap`
`2482`	`2482`	`{`
`2483`	`2483`	`Int4 under = CmpLT(xyz0, Int4(0));`
`2484`		`- xyz0 = (under & maxXYZ) \| (~under & xyz0); // xyz < 0 ? dim - 1 : xyz // FIXME: IfThenElse()`
	`2484`	`+ xyz0 = (under & maxXYZ) \| (~under & xyz0); // xyz < 0 ? dim - 1 : xyz // TODO: IfThenElse()`
`2485`	`2485`
`2486`	`2486`	`Int4 nover = CmpLT(xyz1, dim);`
`2487`	`2487`	`xyz1 = nover & xyz1; // xyz >= dim ? 0 : xyz`