Allow editing headers#41
Merged
gjtorikian merged 2 commits intoskevy:masterfrom Sep 15, 2016
Merged
Conversation
Collaborator
|
Nice! Have you tried running the test locally? Curious to know why it broke. |
Contributor
Author
|
I did and they pass. Not sure why they fail on Travis.
|
Collaborator
|
Well, I confirmed that locally this does what the PR says, so thanks! I know this problem existed before this PR, but would you mind expanding the value text box so that it fits the length of the table? It was weird when adding a header value, but now I think the problem is exacerbated when trying to edit!
|
Contributor
Author
|
Done |
Collaborator
|
Aaaand the test passes because magic. Cool, cool. Thank you! |
|
Has this been released yet? |
|
@hardchor it was merged into master the 16th September. |
Collaborator
|
I don't think it was released yet. I'll try to deploy one when I get the chance. |
|
still no release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
here's a quick go at modifying HTTP headers (#11).