fix: resolve font issue in float environment for cases (https://github.com/sjtug/SJTUThesis/issues/1130)#77
Merged
LogCreative merged 8 commits intosjtug:v2from Jan 3, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a font issue in the cases environment when used inside float environments (issue #1130). The solution nullifies \SJTU@style@equation@font within float contexts by patching the \@floatboxreset command.
Key Changes
- Modified the
\@floatboxresetpatch to set\SJTU@style@equation@fontto empty within float environments - Added documentation explaining the fix and referencing the GitHub issue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexaraWu
requested changes
Jan 3, 2026
sjtutex/source/sjtutex.dtx
Outdated
| % \href{https://github.com/sjtug/SJTUThesis/issues/1130}{SJTUThesis Issue 1130}）， | ||
| % 在浮动体中将 \cs{SJTU@style@equation@font} 置空。 | ||
| % \begin{macrocode} | ||
| \RenewDocumentCommand { \SJTU@style@equation@font } { } { } |
Collaborator
There was a problem hiding this comment.
这里简单点用 \let\SJTU@style@equation@font\@empty 就行。
AlexaraWu
approved these changes
Jan 3, 2026
LogCreative
approved these changes
Jan 3, 2026
Contributor
Author
|
LogCreative
reviewed
Jan 3, 2026
AlexaraWu
pushed a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决 sjtug/SJTUThesis#1130
按照之前的讨论，在浮动体中把
\SJTU@style@equation@font置空