Issue #621: Generate async methods#797
Merged
sjh37 merged 20 commits intosjh37:masterfrom Dec 4, 2023
Merged
Conversation
Contributor
|
Hi, Is there a timeline when this PR will make it to master? KR |
sjh37
approved these changes
Dec 4, 2023
sjh37
added a commit
that referenced
this pull request
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in issue #621, I've updated the templates for all frameworks to generate async methods. Your proposal in issue 621 kind of works, but generates a return model for all stored procedures.
This PR will generate:
I have tested this with EF6 and EF Core 3 myself, for our own projects.
I've also used the Tester projects to generate the provided contexts again, but I noticed a lot of these projects will not compile after regeneration (unrelated to this PR, this is also the case with the current 3.8.0 and 3.8.1 tagged versions).