You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c502be9
Browse filesBrowse the repository at this point in the historyBrowse files
feat(api): return typed deletion outcomes with explicit missing-target semantics (NVIDIA#3317)
* feat(api): return typed deletion outcomes with explicit missing-target semantics
Implement phase 2 of NVIDIA#3051 across the public gateway API and first-party SDKs. Preserve asynchronous sandbox deletion and observed resource identities, reserve legacy wire fields, and document the coordinated migration.
Signed-off-by: Mrunal Patel <[email protected]>
* fix(sdk): bind deletion waits to sandbox identity
Track accepted deletions by original sandbox identity in Rust and TypeScript. Preserve name-only waits and cover replacement races and lookup failures.
Merge the phase-one cleanup fix and adapt its interceptor regressions to typed deletion outcomes.
Refs NVIDIA#3051.
Signed-off-by: Mrunal Patel <[email protected]>
* test(e2e): accept asynchronous stopped sandbox deletion
Allow either completed or accepted deletion output, then continue polling for actual sandbox absence. This preserves the lifecycle assertion under the phase-two deletion contract.
Refs NVIDIA#3051.
Signed-off-by: Mrunal Patel <[email protected]>
---------
Signed-off-by: Mrunal Patel <[email protected]>
Copy file name to clipboardExpand all lines: architecture/gateway.md
+19-2Lines changed: 19 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -59,8 +59,8 @@ write conflicts attach `google.rpc.ErrorInfo` with a stable reason and current
59
59
version when available. `google.rpc.RetryInfo` expresses a minimum retry delay;
60
60
it does not establish that a mutation is safe to repeat. SDKs retain the original
61
61
transport status, metadata, and unknown details alongside decoded fields.
62
-
Python cleanup inspects the original gRPC call beneath a typed error wrapper,
63
-
preserving missing-resource handling without suppressing other failures.
62
+
SDK deletion waits recognize missing-resource status through typed error wrappers
63
+
without suppressing other failures.
64
64
65
65
The gateway listens on one service port and multiplexes gRPC and HTTP traffic.
66
66
The default local single-user deployment mode is mTLS user authentication:
@@ -376,6 +376,23 @@ than extending the frozen message.
376
376
377
377
The descriptor-derived test inventories the complete message and enum closure of the encoded durable roots and its intersection with the public RPC closure. The tables here record the reviewed roots and classifications.
378
378
379
+
Public delete, membership-removal, and SSH-revocation responses use
380
+
`DeletionOutcome`, not a transport-success boolean. `COMPLETED` establishes
381
+
logical gateway deletion or revocation; it does not guarantee that downstream
382
+
platform garbage collection has finished. Sandbox deletion returns `ACCEPTED`
383
+
while its captured object ID remains in the store, and returns that ID so callers
384
+
can distinguish the original sandbox from a same-name replacement. Identity-aware
385
+
SDK deletion waits complete on absence or a different observed ID; name-only waits
386
+
continue until the name is absent. The existing owned deletion worker continues
0 commit comments