Closed
Conversation
Co-authored-by: BlankParticle <[email protected]>
…ompt modeled after codex cli (anomalyco#19220)
…ards better routing (anomalyco#19316)
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Owner
Author
|
Moving to upstream repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes anomalyco#19855
Summary
When pressing Escape to cancel an in-progress LLM generation in the TUI, an unhandled promise rejection stack trace bleeds through to stderr, corrupting the terminal display.
Root Cause
Three fire-and-forget async calls without
.catch()handlers:session.ts:384(primary): The abort HTTP endpoint callsSessionPrompt.cancel()withoutawaitor.catch().cancel()internally callscb.reject(new Error("Session cancelled"))to reject pending promises. Since the endpoint returnsc.json(true)beforecancel()completes, the rejection is unhandled and Bun writes the stack trace to stderr.prompt/index.tsx:262:sdk.client.session.abort()called without.catch()when Escape is pressed twice.prompt/index.tsx:654:sdk.client.session.command()called without.catch().Fixes
session.ts:384:await SessionPrompt.cancel(...).catch(() => {})prompt/index.tsx:262: Added.catch(() => {})to abort callprompt/index.tsx:654: Added.catch(() => {})to command callTest
Added
test/session/cancel.test.ts:SessionPrompt.cancel()rejects pending callbacks without producing unhandled rejectionsNote: Test requires
@ai-sdkdependency fix to run (pre-existing issue withcreateProviderToolFactoryWithOutputSchemaexport).How to reproduce