You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c75affa
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ios): a scoped rotation learns nothing from a panel that did not move
Review of callstack#4440 (cubic): the offset re-derived from the last dispatch and
a same-panel reading assumed that dispatch had landed. A reading taken
before it landed, or a panel whose app cannot show the target, taught a
wrong offset; on the device a portrait-only app made the loop cycle
through six picker values, upside-down included. A reading that still
shows what the panel showed before the last dispatch now teaches nothing
and gets no further dispatch: the loop re-reads, and a panel that never
follows fails unverified after one dispatch.
Also qualify the attempt-budget comment and note that both panels report
lit for a few seconds after an unfold as well as a fold.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Copy file name to clipboardExpand all lines: .changeset/foldable-scoped-rotation.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,4 +2,4 @@
2
2
'agent-device': patch
3
3
---
4
4
5
-
Fix `orientation` on a foldable iPhone simulator (iPhone Duo) in a scoped simulator set. It no longer refuses with `unsupported-device-scope`: the fold helper already reaches a scoped set, so the rotation is dispatched through it and succeeds only when the lit panel shows the requested orientation, otherwise failing with `orientation-unverified-scoped-set`. Measured on iPhone Duo, the lit panel usually reads the orientation-picker value plus a fixed per-panel offset (0 degrees on the outer panel, +90 degrees on the inner panel), and the picker value survives a fold; a panel whose foreground app cannot show that orientation keeps its previous one instead. Each dispatch is therefore the target minus the lit panel's offset, taken from the measured value at first and then recalibrated from the last dispatch and a fresh reading of the same panel, so the first command lands. The fold helper also maps `portrait-upside-down` to the picker's `pud` wire spelling, which the inner panel needs to reach landscape-left; a user target of `portrait-upside-down` stays refused.
5
+
Fix `orientation` on a foldable iPhone simulator (iPhone Duo) in a scoped simulator set. It no longer refuses with `unsupported-device-scope`: the fold helper already reaches a scoped set, so the rotation is dispatched through it and succeeds only when the lit panel shows the requested orientation, otherwise failing with `orientation-unverified-scoped-set`. Measured on iPhone Duo, the lit panel usually reads the orientation-picker value plus a fixed per-panel offset (0 degrees on the outer panel, +90 degrees on the inner panel), and the picker value survives a fold; a panel whose foreground app cannot show that orientation keeps its previous one instead. Each dispatch is therefore the target minus the lit panel's offset, taken from the measured value at first and then recalibrated from the last dispatch and a fresh reading of the same panel, so the first command lands. A reading that has not moved since the last dispatch teaches nothing and is not followed by another dispatch, so a panel that cannot show the target fails after one dispatch. The fold helper also maps `portrait-upside-down` to the picker's `pud` wire spelling, which the inner panel needs to reach landscape-left; a user target of `portrait-upside-down` stays refused.
0 commit comments