I suggest simply exposing logrus.Entry.Log(Level, string) (and logrus.Entry.Logf(Level, string, ...interface{})) and adding a logrus.SetCustomLevelName(Level, string) and logrus.GetCustomLevelName(Level) string, bool which are simply backed by a thread-safe map. Then logrus.Level.String() can use the latter before defaulting to "unknown".

Then we can all simply create levels via:

const TraceLevel = logrus.DebugLevel + 1

func init() {
  logrus.SetCustomLevelName(TraceLevel, "trace")
}

This of course does not solve issues where people may want their level in between other levels. The way to solve that with a backwards compatible impl is to keep the Level type and make a new interface and what not:

type Leveler interface {
  Cmp(other Leveler) int
  LevelString() string
}

func (level Level) Cmp(other Leveler) int {
  switch other := other.(type) {
    case Level:
      if level > other {
        return 1
      } else if level < other {
        return -1
      }
      return 0
    default:
      return -other.Cmp(level)
  }
}

func (level Level) LevelString() string { return level.String() }

Then of course have logrus.Entry.Log(Leveler, string) and logrus.Entry.Logf(Leveler, string, ...interface{}). Granted it may have a bit of performance overhead introducing a type switch in every log statement, but it's a thought. I think the first proposal is good enough to solve people's notice/trace wants (or just go ahead and acknowledge there's a level below debug for many common use cases).

Custom Log Levels #463

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions