Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sirupsen/logrus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.9.2
Choose a base ref
...
head repository: sirupsen/logrus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.9.3
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on May 21, 2023

  1. Revert "Revert "Merge pull request #1376 from ozfive/master"" 

    This reverts commit 352781d.
    @sirupsen
    sirupsen committed May 21, 2023
    Configuration menu
    Copy the full SHA
    f9291a5 View commit details
    Browse the repository at this point in the history

  2. fix panic in Writer 

    Commit 766cfec introduced this bug by defining an incorrect split
function. First it breaks the old behavior because it never splits at
newlines now. Second, it causes a panic because it never tells the
scanner to stop. See the bufio.ScanLines function, something like:
```
if atEOF && len(data) == 0 {
	return 0, nil, nil
}
```
is needed to do that.

This commit fixes it by restoring the old behavior and calling
bufio.ScanLines but also keep the 64KB check in place to avoid buffering
for to long.

Two tests are added to ensure it is working as expected.

Fixes #1383

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99 @sirupsen
    Luap99 authored and sirupsen committed May 21, 2023
    Configuration menu
    Copy the full SHA
    d40e25c View commit details
    Browse the repository at this point in the history
Loading