refactor: import Node built-ins with the node: prefix - #657

What

Every import of a Node.js built-in module now uses the node: prefix: 'fs' → 'node:fs', 'child_process' → 'node:child_process', and likewise for path, os, crypto, https, module, url, util, events, tty and string_decoder. That covers 84 files (30 runtime/script files, 54 test files) and 203 lines. Nothing visible changes and there's no behavior change.

Why

main mixes both styles. Seven runtime files (custom-command.ts, git.ts, git-review-cache.ts, jsonl-blocks.ts, jsonl-cache.ts, jsonl-metrics.ts, CurrentWorkingDir.tsx) and 19 test files already import with node:, and two more tests use it in require(). Meanwhile 30 runtime/script files and 54 test files use bare ids, and 13 files mix both styles in the same import block (for example, git.ts imports 'child_process' next to 'node:fs').

The prefix says plainly that a module is Node's own and can't resolve to an npm package of the same name. Using one style also ends the per-file choice.

The published bundle already contains node: imports, because Bun keeps them as written in dist/. So the minimum Node version the package needs doesn't change (details under How).

How

Every form a module id takes was converted:

• static import / export ... from, including import type
• dynamic import() (ccstatusline.ts, powerline.ts)
• require(): the script the Custom Command widget passes to a child runtime with -e, and the helper scripts tests write to disk and run
• vi.mock() ids in tests

ESLint's import-x/order keeps builtins and packages in one alphabetized group, so its auto-fix moved five imports (https-proxy-agent now sorts before node:*, and node:crypto before node:fs). No other edits.

Mocks. The only built-in mocked by id is child_process, in 30 test files, and all 30 now use vi.mock('node:child_process', ...), the same id the code under test imports. I checked under both Bun's test runner and Vitest on Node that a mock registered under either id applies to static and dynamic imports of both 'child_process' and 'node:child_process'. Neither runner applies mocks to createRequire() calls, so the three tests that use require('node:child_process') to reach the real execFileSync past the mock still get the real one. vi.spyOn on a module namespace sees the same object for 'os' and 'node:os' in both runners. As a control, I pointed each of the 30 mocks at an unused built-in (node:dgram), and 29 files then failed when run alone, so their mocks are in effect. The other one, CompactionCounter.test.ts, passes either way on main too; its mock is a guard those tests never reach.

Minimum Node version. The Custom Command child script now does require('node:child_process'), and require() accepts node: only from Node 16.0 (and 14.18). main's bundle already needs Node 16.6, because its entry chunk calls Array.prototype.at at module load (in get-east-asian-width). Official Node 16.5.0 fails to load both main and this branch with the same ambiguousRanges.at is not a function. Node 16.6.0 renders a Custom Command line identically on both.

Demo

No demo: nothing visible changes.

Testing

• bun run lint: passes.
• bun test (Bun 1.4.2): 2358 pass, 0 fail, 5210 expect() calls across 148 files, the same totals as main. The JUnit reports match main test by test, assertion counts included.
• Suite under Node (Node 26.10.0, node node_modules/vitest/vitest.mjs run --reporter=json): this branch has 2336 tests, 2185 passed, 151 failed in 17 files. A clean main gives the same 151 failures in 17 files, matching test by test; the failures come from spying on Node built-ins, which Node forbids. The only difference: two files that fail at load on both quote the mock id in their error message (No "spawn" export is defined on the "node:child_process" mock). A first main run also failed 5 timing-sensitive TUI/process tests that passed on rerun; this branch had none of them.
• Built CLI under both runtimes (runtime-check.sh refactor/node-protocol-imports, which builds this branch and main):

  Piped render (2 runtimes x plain/powerline):
    plain: all runtimes agree, same as main
    powerline: all runtimes agree, same as main
  TUI smoke (main menu opens, ctrl+c exits cleanly):
    ok    bun-1.4.2
    ok    node-v26.10.0
  

  A rerun that added Node 16.6.0 to the piped renders also reports "all runtimes agree, same as main" for both modes. A Custom Command line (echo hello-from-cmd) renders byte-for-byte the same on main and this branch under Bun 1.4.2, Node 26.10.0 and Node 16.6.0.
• No bare built-in id remains in tracked TS/JS files. Searching every built-in name from require('module').builtinModules, in any from / import / import() / require() / vi.mock() position, matches nothing. Searching for any quoted built-in name at all finds only the 'url' editor-mode literal in src/widgets/Link.tsx, which isn't a module id.