refactor(widgets): share one base class across the Git count widgets - #654

#601 and #499 also touch these files; happy to rebase either way. A sibling PR, #651, does the same for the Git status indicator widgets; the two touch different files, so either can go first.

Demo

After the refactor: in the line editor, r switches Git Staged Files to its raw value and h hides it at zero, then g sets Git Insertions' glyph and both of Git Changes' glyphs. Every case also renders byte-for-byte the same as before; see Testing.

Powerline

Plain

The same six widgets piped from a real repository with staged, unstaged and untracked changes, a clean one, and a directory outside any repository:

Powerline

Plain

Summary

Git Staged, Unstaged and Untracked Files, Insertions, Deletions and Changes each carried their own copy of:

• the editor label, and the "when not in a git repo" and "zero" hide states;
• render: the preview sample, then (no git) outside a work tree, or nothing when that state is hidden, then nothing for a zero count when the zero state is hidden.

The three file-count widgets were also one class written three times, differing only in the count they show, its label, name and color. Insertions and Deletions were nearly the same class too.

GitCountWidgetBase (widgets/shared/git-count-widget.ts) now holds that render and the hide states. Each widget says when its counts are zero and how they show; the preview sample goes through the same formatting. On top of it:

• GitFileCountWidget holds the file counts' git query, the raw-or-labeled format and the numeric value, so Staged, Unstaged and Untracked Files only name their count and label.
• GitLineCountWidget holds the line counts' git query, the preview sample, and the glyph key and editor. Insertions, Deletions and Changes each keep their own zero rule and format.

7 source files, 173 lines added and 330 removed, plus a test file. No visual change.

Testing

• The existing tests for these widgets cover each one's counts and placeholders. The first commit adds widgets/__tests__/GitCountWidgets.test.ts (63 tests) for the rest, checked against the current code before the refactor:

  • all six against the same repositories (dirty, clean, only removed lines, only added lines, only an untracked file, and none), labeled, raw and with each hide state;
  • Git Changes staying visible with the zero state hidden while only one of its counts is zero;
  • the editor label and hide-state labels, the file counts' numeric value, and that a raw item on Insertions, Deletions or Changes still shows its glyph;
  • glyph overrides in a repository, and the glyph editor's rows.

  It passes at both commits under Bun and under Node. Breaking Git Changes' zero rule, a zero-state label, Git Untracked Files' numeric value, Git Deletions' glyph editor, Git Insertions' no-git hide state or Git Staged Files' raw value each makes it fail.

• bun run lint and bun test (2,421 pass).

• Before/after render check: all six widgets rendered on main and on this branch, in every state their own keys reach, raw and labeled, at all three color levels. It ran in the TUI preview and against seven real repositories: staged, unstaged and untracked changes; only staged; only untracked; a merge conflict; clean; no commits yet; and a directory outside any repository. All 420 cases (60 per repository) are byte-identical, as are each widget's editor label and keys. A wider sweep over the same repositories also varied the hide states, glyph overrides (set and emptied) and raw value (on, off, unset): all 4,320 renders are identical, as are each widget's numeric value, hide states, keys and glyph-editor rows.

• Built dist/ and piped a status line with all six widgets through it, from the dirty and the clean repository, in plain and Powerline mode under Bun and Node 16, 18, 20, 22, 24 and 26: every runtime agrees, and the output matches main. The TUI opens and exits cleanly on each.

• Under Node with Vitest, the full suite fails in the same 17 files as main (all from spying on Node built-ins), and the new tests pass.