refactor(widgets): share one searchable list between the locale and timezone editors - #649

#607 and #609 also touch these two editors (both move them behind a lazy loader); happy to rebase either way.

Demo

After the refactor: in the line editor, on a Block Reset Timer in timestamp mode, z opens the timezone list. Searching tokyo and picking Asia/Tokyo moves the preview's reset time to 17:30 GMT+9. l then opens the locale list, and picking ja-JP shows the zone as JST. Every case also renders byte-for-byte the same as before; see Testing.

Powerline

Plain

Summary

The Block Reset Timer and Weekly Reset Timer open a timezone editor with z and a locale editor with l in timestamp mode. The two editors were copies of one searchable list. They differed only in:

• their options and how those are searched (the locale search also offers any valid locale you type);
• which option is selected on open (a configured locale is matched in its canonical form);
• the title, the default shown as Current (en-US, UTC) and the no-match message;
• the setting the picked value is saved to.

SearchableOptionEditor (widgets/shared/searchable-option-editor.tsx) now holds the list: the header and search line, typing and Backspace, Up/Down that wraps and keeps the selection in a ten-row window, Enter to save and ESC to cancel. Each editor passes its options, search, starting value and labels, and saves the picked value to the widget.

3 source files, 221 lines added and 306 removed, plus a test file. No visual change; the editors also draw the same colors as before.

Testing

• The existing editor tests cover searching, saving, the default clearing the setting, a typed custom locale and ESC. The first commit adds widgets/shared/__tests__/searchable-option-editor.test.tsx, which runs the list behavior on both editors:

  • the selection and Current label on open, with and without a configured value;
  • Up and Down wrapping at both ends, and the ten-row window scrolling with the selection;
  • typing and Backspace filtering the list and selecting the first match;
  • the no-match message, with Enter saving nothing;
  • another editor action showing only a notice.

  It passes at every commit under Bun and under Node, 15 or more runs in a row each. Breaking the wrap-around, the selection reset on Backspace, the window's centering or the canonical starting locale makes it fail.

• bun run lint and bun test (2,370 pass).

• Before/after render check: the Block Reset Timer and Weekly Reset Timer rendered on main and on this branch, in every state their own keys reach (42 and 80), raw and labeled, at all three color levels. All 854 preview cases are byte-identical, as are all 1,586 cases in each of two runs with live usage data (reset times in the past and in the future), and each state's editor label and keys. The timezone and locale themselves are only set through these editors, which the tests above cover.

• Built dist/ and piped a status line with both timers in timestamp mode (one set to Europe/Paris and fr-FR), from a payload with rate limits, through it in plain and Powerline mode under Bun and Node 16, 18, 20, 22, 24 and 26: every runtime agrees, and the output matches main. The TUI opens and exits cleanly on each.

• Under Node with Vitest, the full suite fails in the same 17 files as main (all from spying on Node built-ins), and the new tests pass.