Repository navigation
fix(renderer): preserve separators after hidden widgets - #525
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7bd61759
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
j3r0lin
added a commit
to j3r0lin/ccstatusline
that referenced
this pull request
Aug 17, 2026
Resolutions worth naming: - renderer: upstream's sirmalloc#525 fixes the same separator-collapse bug as our b037e8b and handles more cases (a visible separator pops the spacing-only ones before it, and merge ownership survives an empty neighbour), so our resolveEmittedSeparators is dropped in favour of it. Our collapse tests pass unchanged against upstream's implementation. - jsonl-metrics: upstream's compact_boundary handling is ported onto our slim transcript cache. SlimTranscriptEntry gains `c` (boundary) and `p` (postTokens), the pre-filter keeps boundary rows, and the cache version is bumped so existing caches are rebuilt with them. - usage plumbing: the per-model tables now derive from upstream's WEEKLY_MODEL_USAGE_BUCKETS registry; our monthly-pool fields, widgets and the weekly-slot promotion are kept alongside. ANTHROPIC_USAGE_FIELDS also derives its per-model entries from the registry so an upstream model bucket is served rather than filtered out. - CachedUsageDataSchema declares the monthly fields so the schema stays total over UsageData, which keeps UsageDataField indexable.
This was referenced Oct 9, 2026
Closed
tahodev
pushed a commit
to tahodev/ccstatusline
that referenced
this pull request
Oct 20, 2026
* fix(renderer): preserve separators after hidden widgets * fix(renderer): respect separator ownership boundaries * fix(renderer): preserve separators after merged widgets --------- Co-authored-by: Matthew Breedlove <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #518
Prepared with Codex assistance and reviewed against the existing separator regression suite.
Tests
bun testwith 1,811 passing testsbun run lintbun run build