Skip to content

Comments

feat(browser): add keyboard shortcuts menu, add Ctrl+D and Win+Tab shortcuts#44

Merged
wj-xiao merged 3 commits intosipeed:mainfrom
ShuJun-Junical:main
Oct 30, 2025
Merged

feat(browser): add keyboard shortcuts menu, add Ctrl+D and Win+Tab shortcuts#44
wj-xiao merged 3 commits intosipeed:mainfrom
ShuJun-Junical:main

Conversation

@ShuJun-Junical
Copy link
Contributor

example

@MityaResh
Copy link

Hi. Your pullquest is interesting. I would suggest combining all components with shortcuts into one component. Example:

const keycode = KeyboardCodes.get('KeyD')!
const modifiers = new Modifiers();
modifiers.leftCtrl = true;
const label = t('keyboard.ctrlD');

return (
  <Shortcut keycode={keycode} modifiers={modifiers} label={label} />
);

@ShuJun-Junical
Copy link
Contributor Author

I have made modifications and merged all shortcuts into a reusable component shortcut.tsx

@ShuJun-Junical ShuJun-Junical requested a review from wj-xiao May 30, 2025 11:33
@wj-xiao wj-xiao merged commit 22704c7 into sipeed:main Oct 30, 2025
@wj-xiao
Copy link
Collaborator

wj-xiao commented Oct 30, 2025

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants