Skip to content

Comments

fix: right Shift key not working on Japanese keyboards + add Japanese localization#108

Merged
wj-xiao merged 2 commits intosipeed:mainfrom
SingleCores:main
Jan 23, 2026
Merged

fix: right Shift key not working on Japanese keyboards + add Japanese localization#108
wj-xiao merged 2 commits intosipeed:mainfrom
SingleCores:main

Conversation

@SingleCores
Copy link
Contributor

Summary

  • Fix right Shift key not working on Japanese keyboards with Microsoft IME
  • Add Japanese localization for desktop app

Changes

Right Shift Key Fix

Microsoft IME on Windows reports empty event.code for the right Shift key on Japanese keyboards. This PR adds a fallback that maps to ShiftRight when event.code is empty and event.key is Shift.

Related issue: Similar to JetKVM/JetKVM#740

Japanese Localization

Added complete Japanese translation for the desktop application UI.

Test

  • Tested on Windows 11 with Japanese keyboard and Microsoft IME
  • Verified right Shift key now works correctly for uppercase input

@wj-xiao
Copy link
Collaborator

wj-xiao commented Jan 23, 2026

Thanks for your contribution, this is very helpful.

@wj-xiao wj-xiao merged commit f626b47 into sipeed:main Jan 23, 2026
@hiro-gj
Copy link

hiro-gj commented Jan 25, 2026

@wj-xiao @SingleCores
Thank you for the maintenance!

By the way, the installer name in Assets for Releases v1.1.3 was 1.1.2.
https://github.com/sipeed/NanoKVM-USB/releases/tag/v1.1.3

Is this a mistake and it should be 1.1.3?
Perhaps github-actions automatically generated it using the older version 1.1.2?
https://github.com/sipeed/NanoKVM-USB/actions/runs/21282590031

The installer name for release 1 1 3 should be 1 1 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants