fix: right Shift key not working on Japanese keyboards + add Japanese localization#108
Merged
wj-xiao merged 2 commits intosipeed:mainfrom Jan 23, 2026
Merged
fix: right Shift key not working on Japanese keyboards + add Japanese localization#108wj-xiao merged 2 commits intosipeed:mainfrom
wj-xiao merged 2 commits intosipeed:mainfrom
Conversation
Collaborator
|
Thanks for your contribution, this is very helpful. |
|
@wj-xiao @SingleCores By the way, the installer name in Assets for Releases v1.1.3 was Is this a mistake and it should be
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Changes
Right Shift Key Fix
Microsoft IME on Windows reports empty
event.codefor the right Shift key on Japanese keyboards. This PR adds a fallback that maps toShiftRightwhenevent.codeis empty andevent.keyisShift.Related issue: Similar to JetKVM/JetKVM#740
Japanese Localization
Added complete Japanese translation for the desktop application UI.
Test