Don't use the locale-dependant std::to_string()
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
no_to_string
branch
from
dd4e19d to
47e5dc3
Compare
sipa
added a commit
that referenced
this pull request
Feb 18, 2022
55f2ede Update with the latest version of the Bitcoin Core PR (Antoine Poinsot) 3cd71e9 qa: remove the random tests (Antoine Poinsot) c0fda0b Don't use the locale-dependant std::to_string() (Antoine Poinsot) Pull request description: Based on #90. There are a few invasive refactorings. The rename from `NodeType` to `Fragment` can be more easily reviewed with `--word-diff`. ACKs for top commit: sipa: ACK 55f2ede. I have a few nits, but I'll open a PR to address those afterwards. Tree-SHA512: 0195b40bcf46794533e82be1b85c32af58a45c103d262565fb20da89adb9c05a3354e19d77b4c9cbda78c5ef7a4591d10cd021a84a5da618b7a30a28158b8567
Contributor
Author
|
This was merged in #99. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught by the linter check in bitcoin/bitcoin#24147 that i didn't run locally beforehand.. A previous version of this didn't use the variable, but didn't compile on GCC 8.