Miniscript safety #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sipa
reviewed
Sep 28, 2021
sipa
reviewed
Sep 28, 2021
bitcoin/script/miniscript.h
Outdated
|
|
||
| //! Do all sanity checks. | ||
| bool IsSafeTopLevel() const { return GetType() << "Bms"_mst && CheckOpsLimit() && CheckStackSize(); } | ||
| bool IsSane() const { return GetType() << "m"_mst && CheckOpsLimit() && CheckStackSize() && IsValid(); } |
Owner
There was a problem hiding this comment.
Now that there is an IsSane(), perhaps all the ad-hoc sanity checks in the compiler can be replaced with just a call to this? (see Compilation::Add).
Contributor
There was a problem hiding this comment.
Note that this would be updated with k property too based on what gets merged first
…opLevel() Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
Contributor
Author
|
Rebased after #41 merge |
Owner
|
ACK 253172e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #72 this separates
IsSafeandIsSafeTopLevelas suggested in #41 (comment) .