miniscript: account for the witness script push in GetStackSize() #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only returned the satisfaction stack size, but we need to push the actual script first. Signed-off-by: Antoine Poinsot <[email protected]>
Owner
|
ACK e2defc0 |
sipa
added a commit
that referenced
this pull request
Sep 28, 2021
5654e8c test: update stack size tests after GetStackSize() fix (Antoine Poinsot) Pull request description: I forgot to update the tests in #73 ACKs for top commit: sipa: ACK 5654e8c Tree-SHA512: 9139dd3e69a9e9e3250ac76bf5cd599172c4d272c24ae9959f5aec9fcc953c6e6c4e90cac750cda432c71764c373a01188fe1a7013d91b416fcad06e367f5139
Contributor
|
I think we need to revert this commit(and the corresponding commit that fixes the tests). The Script itself is not included in the Stack size check. |
Contributor
Author
Contributor
Author
|
Done in #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only returned the satisfaction stack size, but we need to push the
actual script first.